Review 11.5 Merged

85460[BUGFIX] Mitigate change detection loop for enum and set fields

Stefan Bürk CR +2 V +2 Easy +9 −1 updated 08/06/24, 07:52

Commit message

Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()`
field default values quotes with single quotes, which
leads to an endless field change reporting recursion in
the database analyzer. The default value is now trimmed
to ensure a working field compare within the extending
`TYPO3\CMS\Core\Database\Schema\Comparator` class.

Note that TYPO3 v13 (main) may reveal the same issue but
is shadowed due to the general `ENUM()` and `SET()` type
field issue since Doctrine DBAL 4, reported in #104413.
That needs a change on its own for main only.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 46

  1. Stefan Bürk commented on patch set 1 08/06/24, 07:14

    Cherry Picked from branch 12.4.
  2. core-ci voted on patch set 1 V -1 08/06/24, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62875

  3. Stefan Bürk uploaded patch set 2 V -1 08/06/24, 07:42

  4. core-ci voted on patch set 2 V +1 08/06/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62878

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 08/06/24, 07:52

  6. Stefan Bürk merged patch set 3 08/06/24, 07:52