Review 12.4 Merged

85462[BUGFIX] Replace hardcoded attributes for <span> tags

Benni Mack CR +2 V +2 Easy +18 −7 updated 08/15/24, 08:25

Commit message

This commit fixes the former hard-coded "allowAttribs"
for <span> tags by replacing them with the defined
"allowAttributes" values of the YAML/TSconfig processing
configuration.

In addition, some other fixed lists are moved into class
properties.

Note that to alter the "span" configuration for example
to restrict allowed attributes (or to allow an empty span
tag) you can still use the following YAML/TSconfig:

YAML:
```
processing:
  HTMLparser_db:
    tags:
      span:
        rmTagIfNoAttrib: 0
        allowedAttribs: 'class,data'
```

TSconfig:
```
RTE.default.proc.HTMLparser_db.tags.span {
    rmTagIfNoAttrib = 0
    allowedAttribs = class,data
}
```

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 08/07/24, 12:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/07/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62994

  3. Benni Mack voted on patch set 1 CR +2 V +2 08/07/24, 13:23

  4. Benni Mack merged patch set 2 08/07/24, 13:23

  5. Oliver Hader commented on patch set 2 08/15/24, 08:25