Review 11.5 Merged

85468[BUGFIX] Fix type cast error in DB Compare for 'default' definition

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 09/24/24, 13:43

Commit message

The change in #97498 introduced a specific handling for ENUM/SET
definitions in MariaDB systems. The check may be performed with a
NULL value instead of a string, which can result in a PHP type
mismatch error.

Due to other refactoring, the issue does not exist in main (v13),
but only affects v12 and v11.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jörg Velletti +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Garvin Hicking commented on patch set 1 08/14/24, 12:57

    Cherry Picked from branch 12.4. The following files contain Git conflicts: * typo3/sysext/core/Classes/Database/Schema/EventListener/SchemaColumnDefinitionListener.php
  2. Garvin Hicking uploaded patch set 2 08/14/24, 12:59

    Resolve merge conflict
  3. Garvin Hicking marked it ready for review 08/14/24, 13:00

  4. Stefan Bürk updated the commit message in patch set 3 08/14/24, 13:03

  5. Stefan Bürk voted on patch set 3 CR +1 V +1 08/14/24, 13:04

  6. core-ci voted on patch set 1 V -1 08/14/24, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63377

  7. core-ci voted on patch set 3 V +1 08/14/24, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63382

  8. Stefan Bürk voted on patch set 3 CR +2 V +2 08/14/24, 13:24

  9. Stefan Bürk merged patch set 4 08/14/24, 13:24

  10. Jörg Velletti commented on patch set 4 CR +1 09/24/24, 13:43

    looks fine