Review main Merged

85676[BUGFIX] Remove TCEforms leftovers leading to Exception

Daniel Siepmann CR +2 V +2 Easy +2 −2 updated 08/20/24, 08:46

Commit message

TCEforms were removed with #97126 in v12.
Still there was a usage within EditPopup leading to an Exception when
editing a record with FlexForm via edit form control.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Daniel Siepmann uploaded patch set 1 08/19/24, 05:59

  2. core-ci voted on patch set 1 V +1 08/19/24, 06:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63747

  3. Andreas Kienast voted on patch set 1 CR +1 08/19/24, 09:56

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 08/19/24, 13:58

    Good catch. I grepped the code for other occurrences of "TCEforms", but these were the only ones that would apply.
  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/20/24, 08:19

  6. Christian Kuhn merged patch set 2 08/20/24, 08:46