Review 12.4 Merged

85760[BUGFIX] Extend exceptions thrown by Guzzle (`TransferException`)

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 08/27/24, 19:10

Commit message

In `getUrl()` only a `\GuzzleHttp\Exception\RequestException` is
caught. This piece of code exists since April 20, 2016.

At that time `ConnectException` and `RequestException` were not yet
separated in Guzzle. But that changed in January 2020 and since then,
they both extend `TransferException`.

Thus, now `TransferException` is caught, which includes errorhandling
for both a `RequestException` + `ConnectException`, see [1].

[1] https://github.com/guzzle/guzzle/blob/7.9.2/UPGRADING.md?plain=1#L22

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 08/27/24, 18:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/27/24, 18:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64356

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/27/24, 19:10

  4. Stefan Bürk merged patch set 2 08/27/24, 19:10