Review main Work in progress Orphaned

85828[WIP][TASK] Verify correct constructor arguments in AbstractServiceProvider::new

Benjamin Franzke CR 0 V 0 Easy +4 −3 updated 10/18/24, 13:53

Commit message

TODO:

  * requires a constructor-parameters<> syntax as proposed in
    https://github.com/phpstan/phpstan/issues/8214#issuecomment-1363181807
    => we probably need to write a custom plugin for now

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/85828/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/28/85828/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Merge conflicts 2

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 08/30/24, 08:10

  2. core-ci voted on patch set 1 V +1 08/30/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64517

  3. Benjamin Franzke marked it work in progress 09/18/24, 09:49

  4. Benni Mack updated the commit message in patch set 2 V +1 10/18/24, 13:53