Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Ready for review Orphaned

86090[TASK] Ensure reload of content-container with anchor in url

Ayke Halder CR -1 V 0 Easy +21 −6 updated 09/23/24, 06:58

Commit message

This ensures that an iframe with an anchor in the url is always
reloaded.

This removes any anchor in `ContentContainer.refresh()` calls as the
old anchor might not be a good fit for the current action that
triggers the refresh.
Any action that needs an anchor must use `ContentContainer.setUrl()`
instead.

Before there was no iframe reload at all for
`ContentContainer.setUrl()`, if the new url contains an
anchor - and the old and new url are otherwise identical.

Anchors in iframe urls are used to automatically jump to the defined
position in the newly loaded iframe-document.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/86090/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/86090/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Andreas Kienast -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. main 86112[TASK] Improve performance of reload for recordlist column-selection and clipboard Based on this change Work in progress Merge conflict Ayke Halder CR -1 V -1 Easy +21 −13
  2. 86090 [TASK] Ensure reload of content-container with anchor in url This change

Issues 1

Files 4

Review log 1017

  1. Ayke Halder uploaded patch set 1 09/13/24, 16:49

  2. Ayke Halder updated the commit message in patch set 2 09/13/24, 16:52

  3. core-ci voted on patch set 1 V +1 09/13/24, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65700

  4. core-ci voted on patch set 2 V -1 09/13/24, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65701

  5. Ayke Halder uploaded patch set 3 V -1 09/14/24, 09:11

  6. Ayke Halder updated the commit message in patch set 4 09/14/24, 09:12

  7. Ayke Halder uploaded patch set 5 09/14/24, 09:14

  8. core-ci voted on patch set 4 V +1 09/14/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65747

  9. core-ci voted on patch set 3 V -1 09/14/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65746

  10. core-ci voted on patch set 5 V +1 09/14/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65748

  11. Ayke Halder uploaded patch set 6 V +1 09/15/24, 20:05

  12. core-ci voted on patch set 6 V +1 09/15/24, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65825

  13. Ayke Halder rebased onto patch set 7 V +1 09/19/24, 19:46

  14. core-ci voted on patch set 7 V +1 09/19/24, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66248

  15. Andreas Kienast commented on patch set 7 CR -1 09/20/24, 09:42

    If I understand this correctly, backend modules now forcefully reload every time before jumping to an anchor. I'm highly against such change. Can you please elaborate where in the TYPO3 backend the status quo is an issue?
  16. Benjamin Franzke commented on patch set 7 09/23/24, 06:07

    Do you have a concrete example where this fixed an issue with links in the backend? I'm not convinced we want this, a link to an anchor never create a refresh and I'm not sure we we should do so for backend links. BTW: setting the same URL, with the same anchor *again* would be another story for me, because that could actually be a user-intent to display a fresh variant. Like if a module button would use an anchor link, then I'd expect – as a user – that clicking twice – would reload. But again, I'd like to discuss real issues here, instead of making decisions based on theoretical issues.
  17. Ayke Halder commented on patch set 7 09/23/24, 06:58

    Reply Unresolved

    Good find: there should be no reload when the user clicks on an anchor. Are there actually any jump-links in the TYPO3-Backend? There only should be a reload in case some JS-code replaces the iframe-url.

    Reply Unresolved

    This is needed in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86112/ Currently clipboard and record-tables colum-selection reload the whole TYPO3 backend - instead of just the content-frame. Reloading the whole TYPO3 backend is super slow compared to just reloading the content-frame. (And with the full TYPO3 backend reload any "jump-anchor" in the reload-url gets lost somehow). **Case clipboard:** The clipboard wants to reload the content-frame after there are changes to the clipboard. Therefore the clipboard triggers a reload of the contet-frame - but no reload happens if the current content-frame url contains an anchor. **Case column-selection in record-tables:** After changing the selection of columns to be shown in a record-table (list-module) the content-frame needs a reload. 1. On page https://typo3.cms.ddev.site/typo3/module/web/list?id=1 2. Change "Show columns" of page-records 3. Content-frame url changes to https://typo3.cms.ddev.site/typo3/module/web/list?id=1#t3-table-pages - note: only anchor is added. 4. There must be a reload - not only a "jump". (Without the mentioned patch above, there is a full reload of the TYPO3-Backend in step 3 and the "jump-anchor" is actually lost). ---- The code change here should only be about other JS-code replacing the iframe-url. No intend to change the behaviour when a user clicks a "jump-link". Are there actually any jump-links in the TYPO3-Backend? This needs a further look how to solve the user-clicks-jump-link issue.