Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
86112[TASK] Improve performance of reload for recordlist column-selection and clipboard
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/86112/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/12/86112/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Ayke Halder -1
-
Verified V -1 Blocked
- Oli Bartsch -1
- core-ci +1 CI
Relation chain 2
-
86112 [TASK] Improve performance of reload for recordlist column-selection and clipboard This change
- main 86090[TASK] Ensure reload of content-container with anchor in url
Issues 2
Files 4
Review log 913
-
Ayke Halder uploaded patch set 1 09/15/24, 19:48
-
core-ci voted on patch set 1 V +1 09/15/24, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65823
-
Ayke Halder rebased onto patch set 2
V +109/15/24, 20:06 -
Ayke Halder updated the commit message in patch set 3 09/15/24, 20:11
-
core-ci voted on patch set 2 V +1 09/15/24, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65826
-
core-ci voted on patch set 3 V +1 09/15/24, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65827
-
Ayke Halder uploaded patch set 4
V +109/19/24, 19:49 -
core-ci voted on patch set 4 V +1 09/19/24, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66250
-
Oli Bartsch commented on patch set 4 V -1 11/15/24, 11:08
update for the column selector seems not to work for me. After clicking "Update" the loading indicator stays "for" ever" and the columns list does not refresh. Additionally, it's therefore possible to perform a new update before the previous selection change has been applied. -
Ayke Halder commented on patch set 4 11/15/24, 13:52
Reply
Did you apply this patch here on top of the patch from the relation chain? https://review.typo3.org/c/Packages/TYPO3.CMS/+/86090 -
Oli Bartsch commented on patch set 4 11/15/24, 20:22
Reply
No I did not as this is not described here. However, if this patch requires another patch to be merged first, I suggest to mark this as WIP, since it's not be ready to be reviewed/merged. -
Ayke Halder commented on patch set 4 CR -1 11/15/24, 21:12
Unresolved
Waiting for related change: 86090: [TASK] Ensure reload of content-container with anchor in url | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86090Reply Unresolved
I thought `Related`-issue in the commit-message and `Relation chain` is enough to mark a relation here. -
Benni Mack marked it work in progress 03/21/25, 17:23