Review 12.4 Merged

86221[TASK] Update to CKEditor v43.1

Andreas Nedbal CR +2 V +2 Expert +765 −678 updated 09/20/24, 12:21

Commit message

Executed commands:
   npm --prefix overrides/ckeditor5 version 43.1.0
   npm install --save ./overrides/ckeditor5 $(
     grep @ckeditor/ package.json | \
     grep -v @ckeditor/ckeditor5-dev-utils | \
     grep -v @ckeditor/ckeditor5-inspector | \
     sed 's/^[^"]*"\([^"]*\)".*/\1@43.1.0/' \
   )
   npm run build

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 80

Show 60 more files

Review log 69

  1. Andreas Nedbal commented on patch set 1 09/20/24, 12:00

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/package-lock.json * Build/package.json
  2. core-ci voted on patch set 1 V -1 09/20/24, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66324

  3. Andreas Nedbal uploaded patch set 2 V -1 09/20/24, 12:10

  4. Andreas Nedbal uploaded patch set 3 09/20/24, 12:12

  5. Andreas Nedbal marked it ready for review 09/20/24, 12:14

  6. core-ci voted on patch set 3 V +1 09/20/24, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66326

  7. core-ci voted on patch set 2 V +1 09/20/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66325

  8. Andreas Nedbal voted on patch set 3 CR +2 V +2 09/20/24, 12:20

  9. Andreas Nedbal merged patch set 4 09/20/24, 12:21