Review 12.4 Merged

86321[BUGFIX] Allow saving user preferences with removed password field

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/27/24, 07:57

Commit message

It is possible to disable the backend user password field with
User TSConfig: `setup.fields.password.disabled = 1`

In this case the form value 'password' is not be submitted at all
and missing undefined array key caused PHP warnings (resulting in
errors) which prevented the persistence of user preferences.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/27/24, 07:51

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/27/24, 07:51

  3. core-ci voted on patch set 1 V +1 09/27/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66715

  4. Benjamin Franzke merged patch set 2 09/27/24, 07:57