Review 12.4 Merged

86328[BUGFIX] Make <typo3-backend-icon> CSS backwards compatible

Benjamin Franzke CR +2 V +2 Normal +118 −112 updated 10/04/24, 09:07

Commit message

* Fix positioning in inline contents.
   Inline icon-alignment is done with the `vertical-align: -22%` hack.
   It was introduced for icons by #69005, reintroduced for the icon
   element in #97876 and was then removed again in #99879
   (possibly because of conflicts with block-usage).

 * Fix evaluation of icon-opacity-disabled, which was ignored because
   a semicolon was missing between the variable declaration and
   `display: inline-block`

 * Avoid unneeded icon-unify redefinition via variants. That's
   only used to hide an implicit condition to shadow size=default.
   But that case can rather be expressed using a fallback in the
   var() expression.

 * Ensure that global CSS properties are taken into account
   by avoiding a redefinition via :host() and using var()
   fallbacks instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 4

Files 6

Review log 34

  1. Benjamin Franzke commented on patch set 1 10/04/24, 08:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/04/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67059

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 10/04/24, 09:06

  4. Benjamin Franzke merged patch set 2 10/04/24, 09:07