Review 12.4 Merged

86478[TASK] Stabilize ElementsGroupCest by waiting for modal-iframe load

Stefan Bürk CR +2 V +2 Easy +19 −9 updated 10/10/24, 18:36

Commit message

This makes ElementsGroupCest wait, until the modal-iframe is loaded and
the new "block formatting context" (BFC)  is created, before filling any
data into the search field. About BFC also see [1] and [2].

Before this change the search field was sporadically empty on send,
even though no error for `$I->fillField(…)` was triggered.

Additionally this makes some CSS-selectors more specific.

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/overflow#description
[2] https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_display/Block_formatting_context

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. Stefan Bürk commented on patch set 1 10/10/24, 17:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/10/24, 17:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67527

  3. core-ci commented on patch set 1 10/10/24, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67527

  4. core-ci voted on patch set 1 V +1 10/10/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67527

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 10/10/24, 18:36

  6. Stefan Bürk merged patch set 2 10/10/24, 18:36