86716[TASK] Type DOM query results via type arguments
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 99
- Build/Sources/TypeScript/adminpanel/admin-panel.ts+2 −2
- Build/Sources/TypeScript/backend/code-editor/language/typoscript.ts+1 −1
- Build/Sources/TypeScript/backend/element/contextual-record-edit-trigger.ts+1 −1
- Build/Sources/TypeScript/backend/enum/viewport/scaffold-identifier.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-section-container.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+20 −20
- Build/Sources/TypeScript/backend/form-engine/element/extra/item-count.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/suggest/result-item.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/abstract-sortable-select-items.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/category-element.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/element/group-element.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/element/table-permission-element.ts+4 −4
- Build/Sources/TypeScript/backend/form-engine/field-control/add-record.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/field-control/edit-popup.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/field-control/insert-clipboard.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/field-control/link-popup.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/field-control/list-module.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/field-control/password-generator.ts+4 −4
- Build/Sources/TypeScript/backend/form-engine/field-control/reset-selection.ts+2 −2
Show 79 more files
- Build/Sources/TypeScript/backend/form-engine/field-wizard/value-picker.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/field-wizard/value-slider.ts+2 −2
- Build/Sources/TypeScript/backend/layout-module/drag-drop.ts+15 −15
- Build/Sources/TypeScript/backend/layout-module/page-layout.ts+2 −2
- Build/Sources/TypeScript/backend/layout-module/paste.ts+3 −3
- Build/Sources/TypeScript/backend/layout-module/toggle-hidden-element.ts+1 −1
- Build/Sources/TypeScript/backend/live-search/live-search.ts+6 −6
- Build/Sources/TypeScript/backend/page-wizard/steps/form-engine-step.ts+2 −2
- Build/Sources/TypeScript/backend/security/element/csp-reports.ts+2 −2
- Build/Sources/TypeScript/backend/settings/editor.ts+7 −7
- Build/Sources/TypeScript/backend/tests/notification-test.ts+13 −13
- Build/Sources/TypeScript/backend/toolbar/system-information-menu.ts2+2 −2
- Build/Sources/TypeScript/backend/tree/file-storage-browser.ts+2 −2
- Build/Sources/TypeScript/backend/tree/page-browser.ts+2 −2
- Build/Sources/TypeScript/backend/tree/page-position-select.ts+1 −1
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+2 −2
- Build/Sources/TypeScript/backend/tree/tree-toolbar.ts+1 −1
- Build/Sources/TypeScript/backend/utility/collapse-state-search.ts+1 −1
- Build/Sources/TypeScript/backend/viewport/content-container.ts+1 −1
- Build/Sources/TypeScript/backend/viewport/content-navigation-toggle.ts+2 −2
- Build/Sources/TypeScript/backend/viewport/navigation-container.ts+2 −2
- Build/Sources/TypeScript/backend/wizard/move-content-element.ts+7 −7
- Build/Sources/TypeScript/backend/wizard/move-page.ts+3 −3
- Build/Sources/TypeScript/backend/column-selector-button.ts+2 −2
- Build/Sources/TypeScript/backend/date-time-picker.ts+1 −1
- Build/Sources/TypeScript/backend/drag-uploader.ts+3 −3
- Build/Sources/TypeScript/backend/form-engine-review.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine-suggest.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine-validation.ts+7 −7
- Build/Sources/TypeScript/backend/form-engine.ts+7 −7
- Build/Sources/TypeScript/backend/grid-editor.ts+4 −4
- Build/Sources/TypeScript/backend/image-manipulation.ts+2 −2
- Build/Sources/TypeScript/backend/login-refresh.ts+2 −2
- Build/Sources/TypeScript/backend/login.ts+2 −2
- Build/Sources/TypeScript/backend/mail-link-handler.ts+2 −2
- Build/Sources/TypeScript/backend/modal.ts+1 −1
- Build/Sources/TypeScript/backend/module-menu.ts+1 −1
- Build/Sources/TypeScript/backend/module.ts+1 −1
- Build/Sources/TypeScript/backend/multi-record-selection.ts+2 −2
- Build/Sources/TypeScript/backend/new-record-wizard.ts+1 −1
- Build/Sources/TypeScript/backend/recordlist.ts+6 −6
- Build/Sources/TypeScript/backend/sortable-table.ts+1 −1
- Build/Sources/TypeScript/backend/tab.ts+2 −2
- Build/Sources/TypeScript/backend/telephone-link-handler.ts+1 −1
- Build/Sources/TypeScript/backend/url-link-handler.ts+1 −1
- Build/Sources/TypeScript/belog/backend-log.ts+2 −2
- Build/Sources/TypeScript/beuser/permissions.ts+2 −2
- Build/Sources/TypeScript/extensionmanager/main.ts+1 −1
- Build/Sources/TypeScript/extensionmanager/update.ts+1 −1
- Build/Sources/TypeScript/extensionmanager/upload-form.ts+1 −1
- Build/Sources/TypeScript/filelist/browse-files.ts+2 −2
- Build/Sources/TypeScript/filelist/browse-folders.ts+1 −1
- Build/Sources/TypeScript/filelist/file-list-actions.ts+1 −1
- Build/Sources/TypeScript/filelist/file-list-dragdrop.ts+4 −4
- Build/Sources/TypeScript/filelist/file-list.ts+4 −4
- Build/Sources/TypeScript/filelist/linkbrowser-file-handler.ts+1 −1
- Build/Sources/TypeScript/filelist/rename-file.ts+3 −3
- Build/Sources/TypeScript/filelist/resource-creation.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+2 −2
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+2 −2
- Build/Sources/TypeScript/info/translation-status.ts+2 −2
- Build/Sources/TypeScript/install/module/maintenance/clear-tables.ts+1 −1
- Build/Sources/TypeScript/install/module/maintenance/clear-typo3temp-files.ts+1 −1
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+2 −2
- Build/Sources/TypeScript/install/module/settings/local-configuration.ts+3 −3
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+8 −8
- Build/Sources/TypeScript/install/installer.ts+6 −6
- Build/Sources/TypeScript/install/router.ts+3 −3
- Build/Sources/TypeScript/lowlevel/query-generator.ts+4 −4
- Build/Sources/TypeScript/recycler/recycler.ts+16 −16
- Build/Sources/TypeScript/redirects/short-url-generator.ts+2 −2
- Build/Sources/TypeScript/rte-ckeditor/tests/ckeditor5-test.ts+1 −1
- Build/Sources/TypeScript/scheduler/form-engine/element/timing-options-element.ts+1 −1
- Build/Sources/TypeScript/scheduler/scheduler-add-group.ts+1 −1
- Build/Sources/TypeScript/scheduler/scheduler-sortable-groups.ts+2 −2
- Build/Sources/TypeScript/styleguide/find-icons.ts+1 −1
- Build/Sources/TypeScript/viewpage/main.ts+7 −7
- Build/Sources/TypeScript/workspaces/backend.ts+28 −28
- Build/Sources/TypeScript/workspaces/preview.ts+8 −8
Review log 1825
-
Ayke Halder uploaded patch set 1 10/23/24, 16:09
-
core-ci voted on patch set 1 V +1 10/23/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68468
-
Ayke Halder rebased onto patch set 2
V +110/23/24, 22:10 -
core-ci voted on patch set 2 V +1 10/23/24, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68489
-
Benjamin Franzke commented on patch set 2 CR -2 10/24/24, 02:27
You don't actually do that, as a lot of placing where `querySelector` is modified do not include the possibility to become `null`. Sorry, I can not trust this change at all. It looks quite good and I also like assertions via generics more than blunt type assertion, but they are still essentially the same and bring no improvement when used incorrectly. Also see https://review.typo3.org/c/Packages/TYPO3.CMS/+/86724/2#message-5f1e0f79226e22b15f80daff583ff5f488c6104f -
Ayke Halder commented on patch set 2 10/24/24, 10:05
Reply
> You don't actually do that, as a lot of placing where `querySelector` is modified do not include the possibility to become `null`. Sorry I don't really get the meaning of this sentence - language barrier. Is it A: "In general you don't actually do that, as a lot of placing where `querySelector` is modified, are known - by taking further knowledge from outside of the code into account - to never become `null`. Or is it B: "This change here does not do the implementation as described in its commit message." -
Benjamin Franzke commented on patch set 2 03/27/25, 13:20
Reply
Commit message describes B, but code does A. I understand the urge to apply "A" (because it is annoying to check every place for null without it ever happening), but it makes it hard to review, as we need to verify if your assumption that the selector will not resolve into `null` is true. -
Ayke Halder commented on patch set 2 03/27/25, 13:40
Reply
I'll try to check if I properly understand your point with these code examples. Example 1: not easily reviewable - missing null-check: ```js this.valueSlider = this.querySelector('input') as HTMLInputElement; new ThrottleEvent('input', this.handleRangeChange, 25).bindTo(this.valueSlider); . ``` Example 2: easily reviewable - null-check implemented: ```js this.valueSlider = this.querySelector('input') as HTMLInputElement|null; if (this.valueSlider !== null) { new ThrottleEvent('input', this.handleRangeChange, 25).bindTo(this.valueSlider); } . ``` -
Ayke Halder commented on patch set 2 10/16/26, 09:07
Reply
No reply: @ben@bnf.dev please remove your double down-vote her. -
Benjamin Franzke commented on patch set 2 CR -1 10/16/26, 12:33
Reply
Sorry, but you didn't update the code and the code was blocked as is. Anyway, changing to -1 (so a push that fixes thing can remove the vote), so you're not blocked by me. -
Benjamin Kott uploaded patch set 3
CR -1V +110/23/26, 10:30 -
Benjamin Kott updated the commit message in patch set 4 10/23/26, 10:44
-
Benjamin Kott updated the commit message in patch set 5 10/23/26, 10:45
-
core-ci voted on patch set 3 V +1 10/23/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112268
-
core-ci voted on patch set 4 V +1 10/23/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112271
-
core-ci voted on patch set 5 V +1 10/23/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112274
-
Benjamin Franzke commented on patch set 5 10/23/26, 11:44
Reply
> You don't actually do that, as a lot of placing where querySelector is modified do not include the possibility to become null. Hey, me again. With the rewritten patch and by reviewing the changes (also your patchset 2 again) I noticed I was completely wrong here. I think I thought back then that `querySelector<FooElement>` causes the return type to be considered `FooElement` instead of `FooElement|null`, while null is preserved. I know that you wanted to express that, but I simply didn't get it. I'm sorry! -
Benjamin Franzke commented on patch set 5 10/23/26, 11:47
system-information-menu.ts:64This unnecessary type declaration is removed in column-selector-button.ts, can it be removed in here (and similar cases) as well? -
Benjamin Kott uploaded patch set 6
V +110/23/26, 11:48 -
Benjamin Kott uploaded patch set 7 10/23/26, 11:51
-
core-ci voted on patch set 6 V +1 10/23/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112286
-
core-ci voted on patch set 7 V +1 10/23/26, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112288
-
Benjamin Franzke commented on patch set 7 CR +1 V +1 10/23/26, 12:06
system-information-menu.ts:64ReplyDone -
Benjamin Kott voted on patch set 7 CR +2 V +2 10/23/26, 12:06
-
Benjamin Kott merged patch set 8 10/23/26, 12:27