#105417 ESLint: Prepare for `@typescript-eslint/no-unnecessary-type-assertion` rule
Description
There are some type assertions that cover up that a value might be null on run-time as actually no element is found.
Current implementation
this.clearableElements = document.querySelectorAll('.t3js-clearable') as NodeListOf<HTMLInputElement>;
const targetElement = parentElement.querySelector('button[data-bits="' + bits + '"]') as HTMLButtonElement;
<HTMLInputElement>document.querySelector('input[name="' + e.data.fieldName + '"]');
——
Implementation with null
IMO the type assertion should not remove the null possibility – and could look like this:
this.clearableElements = document.querySelectorAll('.t3js-clearable') as NodeListOf<HTMLInputElement|null>;
const targetElement = parentElement.querySelector('button[data-bits="' + bits + '"]') as HTMLButtonElement|null;
<HTMLInputElement|null>document.querySelector('input[name="' + e.data.fieldName + '"]');
——
Improved implementation with null
To further improve use the following type assertion for find/@closest@/@querySelector@/@querySelectorAll@, as this will give the proper type including the null-possibility:
this.clearableElements = document.querySelectorAll<HTMLInputElement>('.t3js-clearable');
const targetElement = parentElement.querySelector<HTMLButtonElement>('button[data-bits="' + bits + '"]');
const field = document.querySelector<HTMLInputElement>('input[name="' + e.data.fieldName + '"]');Reviews 4
Related issues 1
History 211
-
Gerrit Code Review pushed patch set 1 for main to change 86716 status
NewUnder Review <span data-processor="relativetime" data-value="2024-10-23T16:09:38+00:00" > 10/23/24, 16:09 </span> -
Ayke Halder changed Related to #105423 <span data-processor="relativetime" data-value="2024-10-23T20:41:09+00:00" > 10/23/24, 20:41 </span>
-
Gerrit Code Review pushed patch set 2 for main to change 86716 <span data-processor="relativetime" data-value="2024-10-23T22:10:46+00:00" > 10/23/24, 22:10 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 86716 <span data-processor="relativetime" data-value="2026-10-23T10:30:14+00:00" > 10/23/26, 10:30 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 86716 <span data-processor="relativetime" data-value="2026-10-23T10:44:47+00:00" > 10/23/26, 10:44 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 86716 <span data-processor="relativetime" data-value="2026-10-23T10:45:53+00:00" > 10/23/26, 10:45 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 86716 <span data-processor="relativetime" data-value="2026-10-23T11:48:40+00:00" > 10/23/26, 11:48 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 86716 <span data-processor="relativetime" data-value="2026-10-23T11:51:39+00:00" > 10/23/26, 11:51 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97075 <span data-processor="relativetime" data-value="2026-10-23T12:07:37+00:00" > 10/23/26, 12:07 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97075 <span data-processor="relativetime" data-value="2026-10-23T12:10:28+00:00" > 10/23/26, 12:10 </span>
-
Ayke Halder commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-10-23T12:30:16+00:00" > 10/23/26, 12:30 </span>
Applied in changeset commit:01752b13fbe8f1616576ae1ca71a5da6d139a0ba.