Review 13.4 Merged

86739[BUGFIX] Handle `severity` configuration in `FlashMessage` finisher properly

Andreas Kienast CR +2 V +2 Easy +17 −13 updated 10/25/24, 09:32

Commit message

The definition of the `FlashMessage` form finisher accepts the option
`severity` to be set. With the introduction of
`ContextualFeedbackSeverity`, migration was not properly handled as Yaml
can only take literal values.

From a technical point of view it's possible to use the `!php/enum` flag
in the Yaml configuration, which forces us to enable constant parsing
via `Yaml::PARSE_CONSTANT`, opening another can of worms which we want
to avoid here at any cost.

This patch reverts the deprecation of the integer-based severity to
allow configuring the severity via Yaml again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 3

Files 2

Review log 34

  1. Andreas Kienast commented on patch set 1 10/25/24, 09:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/25/24, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68602

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 10/25/24, 09:32

  4. Andreas Kienast merged patch set 2 10/25/24, 09:32