Review 13.4 Merged

86852[BUGFIX] Ensure same RecordIdentityMap for cloned PageLayoutContext

Oli Bartsch CR +2 V +2 Easy +1 −3 updated 10/30/24, 16:31

Commit message

In BackendLayoutRenderer the PageLayoutContext is cloned in case
we are in "layout" mode and a "language" is selected. The problem is
at the time of cloning, the property "recordIdentityMap" is not yet
initialized. And when calling `getGridForPageLayoutContext`, the
original context is initialized with this property and filled with
discovered Content Elements. In order to have the same identity map
in the cloned context, the map is now instantiated in the constructor
instead of lazily in the get method.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 10/30/24, 16:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/30/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68860

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/30/24, 16:31

  4. Oli Bartsch merged patch set 2 10/30/24, 16:31