Review 12.4 Merged

86856[BUGFIX] Allow BE user compare with outdated page content types

Garvin Hicking CR +2 V +2 Easy +17 −3 updated 11/05/24, 09:18

Commit message

If groups of a BE user refer to outdated/removed page content
types, an exception in translating an empty label is no longer
thrown.

Instead, the label is displayed as "N/A" and the debug fieldname
will be fully revealed.

Also, the shortened debug fieldname will now be available as
extra information.

A drive-by bugfix is applied to ignoring an improper
user language reference which can also occur on "outdated"
user/group information, which can happen during updates and should
not lead to PHP exceptions at this point.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1115

  1. Garvin Hicking commented on patch set 1 10/31/24, 09:56

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/beuser/Classes/Service/UserInformationService.php * typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html
  2. core-ci voted on patch set 1 V -1 10/31/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68903

  3. Garvin Hicking commented on patch set 2 V -1 10/31/24, 10:08

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/31/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68904

  5. Mathias Brodala commented on patch set 2 CR -1 10/31/24, 10:25

    Information.html:348

    We are missing the "type" key here and the output afterwards. As mentioned in the ticket, this is essential for debugging.
  6. Garvin Hicking uploaded patch set 3 CR -1 V +1 10/31/24, 11:22

    Adapt to main
  7. core-ci voted on patch set 3 V +1 10/31/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68910

  8. Garvin Hicking marked it ready for review 10/31/24, 11:30

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 10/31/24, 11:30

    Done, see main patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/85863 for notes on this backport

    Information.html:348 Reply

    Done
  10. Garvin Hicking commented on patch set 4 CR +1 V +1 10/31/24, 11:38

    Published edit on patch set 3.
  11. core-ci voted on patch set 4 V +1 10/31/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68914

  12. Mathias Brodala commented on patch set 4 V -1 10/31/24, 11:48

    Information.html:353

    We definitely also need the debug output here since the item label can be empty.
  13. Mathias Brodala commented on patch set 4 CR +1 V +1 10/31/24, 11:52

    Information.html:353 Reply

    As discusses this is another issue. In v13/main the code is always shown on debug which was unfortunately not backported.
  14. Garvin Hicking voted on patch set 4 CR +2 V +2 11/05/24, 09:17

  15. Garvin Hicking merged patch set 5 11/05/24, 09:18