86856[BUGFIX] Allow BE user compare with outdated page content types
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Mathias Brodala +1
-
Verified V +2 Done
- Garvin Hicking +2
- Mathias Brodala +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1115
-
Garvin Hicking commented on patch set 1 10/31/24, 09:56
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/beuser/Classes/Service/UserInformationService.php * typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html -
core-ci voted on patch set 1 V -1 10/31/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68903
-
Garvin Hicking commented on patch set 2
V -110/31/24, 10:08Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 10/31/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68904
-
Mathias Brodala commented on patch set 2 CR -1 10/31/24, 10:25
Information.html:348We are missing the "type" key here and the output afterwards. As mentioned in the ticket, this is essential for debugging. -
Garvin Hicking uploaded patch set 3
CR -1V +110/31/24, 11:22Adapt to main -
core-ci voted on patch set 3 V +1 10/31/24, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68910
-
Garvin Hicking marked it ready for review 10/31/24, 11:30
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/31/24, 11:30
Done, see main patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/85863 for notes on this backportInformation.html:348ReplyDone -
Garvin Hicking commented on patch set 4
CR +1V +110/31/24, 11:38Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 10/31/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68914
-
Mathias Brodala commented on patch set 4 V -1 10/31/24, 11:48
Information.html:353We definitely also need the debug output here since the item label can be empty. -
Mathias Brodala commented on patch set 4 CR +1 V +1 10/31/24, 11:52
Information.html:353ReplyAs discusses this is another issue. In v13/main the code is always shown on debug which was unfortunately not backported. -
Garvin Hicking voted on patch set 4 CR +2 V +2 11/05/24, 09:17
-
Garvin Hicking merged patch set 5 11/05/24, 09:18