Review 13.4 Merged

86865[BUGFIX] Remove slow MySQL table index queries

Benjamin Franzke CR +2 V +2 Normal +31 −160 updated 11/04/24, 10:13

Commit message

Querying `information_schema.STATISTICS` for every index
(that has already been fetched from `information_schema.STATISTICS`)
causes superfluous queries and slows down database comparision
drastically (~350 uneeded queries), neglecting the performance
improvements that have been applied upstream:
https://github.com/doctrine/dbal/pull/5268

The table index query has been introduced with #78024 to
parse the index prefix length into the column name.
It turns out this parsing can be done without additional
database queries since https://github.com/doctrine/dbal/pull/2412

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/04/24, 10:00

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/04/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69025

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/04/24, 10:13

  4. Benjamin Franzke merged patch set 2 11/04/24, 10:13