Review 13.4 Merged

86866[BUGFIX] Use platform specific doctrine/dbal schema comparators

Benjamin Franzke CR +2 V +2 Hard +228 −126 updated 11/04/24, 10:54

Commit message

The MySQL schema comparator is aware of the fact that a column's
character set is to be inherited from its containing table, when
`TYPO3_CONF_VARS.DB.Connections.{connection}.defaultTableOptions`
is not sets.

The TYPO3 comparator wrapper implementation effectively
disabled the upstream platform adjustments for MySQL (and sqlite,
which has an own comparator as well), which is now fixed
by using a decorator pattern instead of inheritance which does
not allow to pull in platform specific comparator code.

The table options comparison is no longer done in `compareTables`,
but applied as an additional step (as the different upstream comparator
implementations are not modifiable by inheritance).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/04/24, 10:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/04/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69028

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/04/24, 10:53

  4. Benjamin Franzke merged patch set 2 11/04/24, 10:54