Review 13.4 Merged

86869[BUGFIX] Ensure existing preview popup windows are focussed

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 11/04/24, 18:09

Commit message

When a frontend preview is executed from within the backend,
a window/tab will open with that location. Another preview
will re-use that existing window/tab and only reload its
location.

However, a `focus()` call was only issued for fresh tabs,
and existing tabs would not necessarily receive focus.
To ensure this accross browsers, the `focus()` is
specifically addressed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/04/24, 16:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/04/24, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69047

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/04/24, 18:08

  4. Benjamin Franzke merged patch set 2 11/04/24, 18:09