Review 13.4 Merged

86899[BUGFIX] Show last page of live search with different result-groups

Garvin Hicking CR +2 V +2 Easy +12 −4 updated 11/07/24, 06:51

Commit message

If the last page of the live search consists of entries from different
search-providers like Pages and Records it renders correctly now.

Before the counting of total-count of items was wrong. Thereby
`array_fill()` was called with a negative value for the parameter
`count` which resulted in a `ValueError`.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 11/06/24, 16:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/06/24, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69152

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/07/24, 06:51

  4. Garvin Hicking merged patch set 2 11/07/24, 06:51