Review 13.4 Merged

86904[BUGFIX] Apply InnoDB as default to CREATE TABLE options

Benjamin Franzke CR +2 V +2 Hard +260 −40 updated 11/07/24, 11:46

Commit message

Our database schema relies on InnoDB for certain indexes.
The entry_identifier key size of the sys_registry is 1024
(`(128 + 128) * 4 = 1024`) when using a 4-byte utf8mb4 charset,
which exceeds the MySQL MyISAM limit of 1000 bytes per key.

Ensure that we apply InnoDB as a default for all tables (instead
of defining it explicitly for only some table and therefore miss
relevant ones).

Ensure we also create migrations to switch tables to InnoDB that do
not explicitly list ENGINE=MyISAM in their table options.

Also default to ROW_FORMAT=Dynamic to ensure existing
`ENGINE=MyISAM ROW_FORMAT=Fixed` tables can be switched to InnoDB
which does not support ROW_FORMAT=Fixed in strict mode.

See https://dev.mysql.com/doc/refman/5.7/en/create-table.html:
> For InnoDB tables:
> * …
> * ROW_FORMAT=FIXED is not supported. If ROW_FORMAT=FIXED is specified
>   while innodb_strict_mode is disabled, InnoDB issues a warning and
>   assumes ROW_FORMAT=DYNAMIC. If ROW_FORMAT=FIXED is specified while
>   innodb_strict_mode is enabled, which is the default, InnoDB returns
>   an error.

The AboutDatabaseErrorRowSizeTooLarge is updated to reflect this change.
The previous section that describe these actions as manual checks have
been removed in order to reduce the amount of manual maintenance that an
integrator has to perform for a TYPO3 update.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/07/24, 11:36

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/07/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69179

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/07/24, 11:46

  4. Benjamin Franzke merged patch set 2 11/07/24, 11:46