Review 13.4 Merged

86933[BUGFIX] Apply defaultTableOptions to CREATE TABLE DEFAULTS

Benjamin Franzke CR +2 V +2 Easy +47 −0 updated 11/11/24, 11:58

Commit message

The configured defaultTableOptions are now also applied to default
table options (not just to column definitions) to prevent mixed
scenarios, where columns have been updated to a newer charset
(like utf8mb4), but the table option defaults stayed at utf8.

Example (based on `show create table sys_note`) where the text column
charsets is utf8mb4 but table defaults were still set to utf8:

```
CREATE TABLE `sys_note` (
  `uid` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `subject` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '',
  `message` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  PRIMARY KEY (`uid`),
  KEY `parent` (`pid`,`deleted`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci
```

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/11/24, 11:46

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/11/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69303

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/11/24, 11:58

  4. Benjamin Franzke merged patch set 2 11/11/24, 11:58