Review 13.4 Merged

86935[TASK] Revert "[TASK] Improve debug output of PAGEVIEW"

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 11/11/24, 16:27

Commit message

This reverts commit de1d92aab19b5c34105374090d89db8548a7e592.

Reason for revert:
The adressed debugging usability issue (the nested evaluation of the
language object in scope of the site object in output of <f:debug>)
has been adressed by #105043.

That means we can go back to logical ordering that reflects the
order how these variables have been resolved by the middleware
stack and are therefore logically tangible:

 * The `site` is resolved based on a request
 * The `language` is resolved based on a site of the request
 * The `page` is resolved based on the `site` and `language`

This logical structure helps developers to get a comprehensible overview
of variables instead of having to grasp a random ordered pile of
variables.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/11/24, 16:17

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/11/24, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69309

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/11/24, 16:27

  4. Benjamin Franzke merged patch set 2 11/11/24, 16:27