Review 12.4 Merged

86941[DOCS] Hint LanguageService->sL() docs on placeholder usage

Garvin Hicking CR +2 V +2 Easy +35 −0 updated 11/14/24, 09:38

Commit message

The inline code comment is used for rendering the documentation
at [1]. It currently is missing information that LanguageService->sL()
is not doing any placeholder interpolation, and that this needs
to be performed individually.

People may lean towards using Extbase LocalizationUtility in
a wrong context, because that offers placeholder substitution.

[1] https://docs.typo3.org/permalink/t3coreapi:LanguageService-api

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 11/14/24, 09:22

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/14/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69427

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/14/24, 09:38

  4. Garvin Hicking merged patch set 2 11/14/24, 09:38