Review 13.4 Merged

87083[BUGFIX] Resolve RecordPropertyClosure for flex fields

Oli Bartsch CR +2 V +2 Hard +415 −27 updated 11/19/24, 15:10

Commit message

This introduces a new model class `FlexFormFieldValues`,
which represents a record's flex field values. By
implementing `ContainerInterface` and `ArrayAccess`,
it allows to access the property values in fluid
templates with various available syntaxes. Most
importantly, in case a flex field value is a
`RecordPropertyClosure`, it's now resolved properly.
This works recursively and the resolved value is
"persisted" so does not need to be resolved again.

Support for fields with dot syntax, e.g. "some.field"
is implemented as well.

Due to `ContainerInterface` and `ArrayAccess`,
accessing such property is possible via:

- $field['some']['field']
- $field->get('some')['field']
- $field->get('some.field')

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 34

  1. Oli Bartsch commented on patch set 1 11/19/24, 14:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/19/24, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69718

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/19/24, 15:10

  4. Oli Bartsch merged patch set 2 11/19/24, 15:10