Review 13.4 Merged

87090[BUGFIX] Prevent PHP error with empty link tag

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 11/19/24, 21:03

Commit message

If `<f:link.action />` is called with invalid parameters (e. g. a
non-existent page uid), the uri generation fails and returns an empty
string instead. In that case, only the provided tag content is used,
without any `<a>` tag. This fails with a PHP type error if no content
is provided and `$this->renderChildren()` returns `null`. That value
is now cast to a string to prevent the type error.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 11/19/24, 18:11

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/19/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69740

  3. Simon Praetorius voted on patch set 1 CR +2 V +2 11/19/24, 21:02

  4. Simon Praetorius merged patch set 2 11/19/24, 21:03