Review 13.4 Merged

87118[BUGFIX] Fix showing of parent items in select tree filtering

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 11/20/24, 16:11

Commit message

Multiple issues existed when filtering lists of a depth of at least 2:

* In the list of parents, the first element was used,
  which is usually the identifier '0', to recursively
  show the parents, we need to use the last element.

* Using the identifier directly to access an element
  inside this.nodes was wrong too because that would
  use the identifier as an array index, breaking on
  IDs that are higher than the node element count.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 11/20/24, 15:39

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree.js
  2. core-ci voted on patch set 1 V -1 11/20/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69805

  3. Andreas Nedbal uploaded patch set 2 V -1 11/20/24, 15:50

  4. Andreas Nedbal marked it ready for review 11/20/24, 15:51

  5. core-ci voted on patch set 2 V +1 11/20/24, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69809

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 11/20/24, 16:11

  7. Garvin Hicking merged patch set 3 11/20/24, 16:11