Review 12.4 Merged

87122[TASK] Add functional DataHandler tests for type=datetime

Benjamin Franzke CR +2 V +2 Hard +511 −0 updated 11/20/24, 21:27

Commit message

Add functional DataHandler tests for type=datetime that assert correct
persistence to database and test in different timezones.

We document current findings and oddities which are to be streamlined
by #105549 in TYPO3 v14.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 13

Review log 913

  1. Benjamin Franzke commented on patch set 1 11/20/24, 18:37

    Cherry Picked from branch main.
  2. Benjamin Franzke uploaded patch set 2 11/20/24, 18:44

  3. Benjamin Franzke uploaded patch set 3 11/20/24, 18:44

  4. Benjamin Franzke uploaded patch set 4 11/20/24, 18:46

  5. Benjamin Franzke uploaded patch set 5 11/20/24, 18:47

  6. core-ci voted on patch set 5 V +1 11/20/24, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69848

  7. Benjamin Franzke uploaded patch set 6 V +1 11/20/24, 18:54

  8. core-ci voted on patch set 6 V +1 11/20/24, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69849

  9. Benjamin Franzke uploaded patch set 7 V +1 11/20/24, 20:11

  10. core-ci voted on patch set 7 V -1 11/20/24, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69865

  11. core-ci voted on patch set 7 V +1 11/20/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69865

  12. Benjamin Franzke commented on patch set 7 CR +2 V +2 11/20/24, 21:15

    This change is ready for review.
  13. Benjamin Franzke merged patch set 8 11/20/24, 21:27