Review 13.4 Merged

87123[TASK] Make `SvgSpriteIconProvider` "public"

Andreas Kienast CR +2 V +2 Easy +2 −4 updated 11/20/24, 19:35

Commit message

The `SvgSpriteIconProvider` has been added with 10.4 and is proven to be
stable in use. This commit removes the `@internal` annotation and fixes
some minor issues.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Andreas Kienast commented on patch set 1 11/20/24, 19:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/20/24, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69854

  3. core-ci voted on patch set 1 V +1 11/20/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69854

  4. Andreas Kienast voted on patch set 1 CR +2 V +2 11/20/24, 19:34

  5. Andreas Kienast merged patch set 2 11/20/24, 19:35