Review 13.4 Merged

87125[BUGFIX] Children of selectTree filter should be expandable

Andreas Nedbal CR +2 V +2 Easy +24 −8 updated 11/20/24, 19:39

Commit message

This patch changes the behaviour of TCA renderType selectTree
filter so that it is possible to see unfiltered children of
nodes for which the filter matches. Previously, all nodes
were hidden if the filter did not match them.

Now, the behaviour initially looks the same, but it is possible
to expand the lowest filtered node and see the unfiltered
children (as in the page tree).

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
  • Verified V +2 Done
    • Andreas Nedbal +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Nedbal commented on patch set 1 11/20/24, 19:16

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree.js
  2. Andreas Nedbal uploaded patch set 2 11/20/24, 19:18

  3. Andreas Nedbal marked it ready for review 11/20/24, 19:19

  4. core-ci voted on patch set 1 V -1 11/20/24, 19:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69857

  5. core-ci voted on patch set 2 V +1 11/20/24, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69858

  6. Andreas Nedbal voted on patch set 2 CR +2 V +2 11/20/24, 19:39

  7. Andreas Nedbal merged patch set 3 11/20/24, 19:39