Review 13.4 Merged

87173[BUGFIX] Show hash to user even if InstallTool password is invalid

Simon Praetorius CR +2 V +2 Easy +12 −4 updated 11/21/24, 19:29

Commit message

Currently, if a user uses an invalid InstallTool password hash,
for example a plaintext placeholder, the InstallTool login
throws an uncaught `InvalidPasswordHashException`.

This prevents the output of the generated hash based on
the entered password, which could then be used to fix the
issue by setting a valid InstallTool password in the
configuration.

With this change, the exception is caught and is written
to the log file instead. The user is shown the normal login
screen with the generated hash.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Simon Praetorius commented on patch set 1 11/21/24, 18:37

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/21/24, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69978

  3. Simon Praetorius voted on patch set 1 CR +2 V +2 11/21/24, 19:29

  4. Simon Praetorius merged patch set 2 11/21/24, 19:29