Review 12.4 Merged

87182[BUGFIX] Return HTTP 400 if request is invalid

Benni Mack CR +2 V +2 Easy +17 −2 updated 11/22/24, 12:18

Commit message

The request may be an unparsable URL or might
have other defects.

Specifically, the URI class may throw an
exception if something is wrong.
Catch this exception and bail out with a
400 bad request status.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 11/22/24, 09:55

    Cherry Picked from branch 13.4. The following files contain Git conflicts: * typo3/sysext/backend/Classes/ServiceProvider.php * typo3/sysext/core/Classes/ServiceProvider.php * typo3/sysext/frontend/Classes/ServiceProvider.php
  2. core-ci voted on patch set 1 V -1 11/22/24, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70025

  3. Markus Klein uploaded patch set 2 V -1 11/22/24, 10:07

  4. core-ci voted on patch set 2 V +1 11/22/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70027

  5. Benni Mack marked it ready for review 11/22/24, 10:18

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/22/24, 12:18

  7. Benni Mack merged patch set 3 11/22/24, 12:18