Review 13.4 Merged

87252[TASK] Enable AVIF support for ImageMagick

Garvin Hicking CR +2 V +2 Hard +213 −45 updated 12/18/24, 17:47

Commit message

Since GIFBUILDER already supports AVIF through the GDlib functions,
it would be expected to have ImageMagick support for transforming
regular images as well.

This task adds this functionality, exposes the checks for it
through the "reports" module and the environment check for image
generation.

The output of "convert -list format" is parsed (like for webp
support) to detect avif support. GraphicsMagick does not offer
writing AVIF formats yet. A messsage is emitted to hint
at possible missing support for writing this format.

Since MIME-Type detection wrongfully returns
"image/heif" for .avif file types, the proper MIME-Type
(image/avif) is added to `$GLOBALS['TYPO3_CONF_VARS']['SYS']`
`['FileInfo']['fileExtensionToMimeType']`.

The image testing module also is streamlined for some
spelling fixes and proper GraphicsMagick mentions.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 916

  1. Garvin Hicking commented on patch set 1 11/27/24, 10:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/27/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70245

  3. Garvin Hicking commented on patch set 2 V -1 11/27/24, 10:32

    Cherry Picked from branch main.
  4. core-ci voted on patch set 2 V +1 11/27/24, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70248

  5. Garvin Hicking rebased onto patch set 3 V +1 12/05/24, 09:17

  6. Garvin Hicking commented on patch set 4 12/05/24, 09:18

    Published edit on patch set 3.
  7. core-ci voted on patch set 3 V +1 12/05/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70633

  8. core-ci voted on patch set 4 V +1 12/05/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70634

  9. Garvin Hicking commented on patch set 5 V +1 12/11/24, 11:13

    Cherry Picked from branch main.
  10. core-ci voted on patch set 5 V +1 12/11/24, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70915

  11. Garvin Hicking updated the commit message in patch set 6 V +1 12/11/24, 11:28

  12. core-ci voted on patch set 6 V +1 12/11/24, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70920

  13. Garvin Hicking commented on patch set 7 V +1 12/17/24, 15:38

    Cherry Picked from branch main.
  14. core-ci voted on patch set 7 V +1 12/17/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71293

  15. Garvin Hicking voted on patch set 7 CR +2 V +2 12/18/24, 17:47

  16. Garvin Hicking merged patch set 8 12/18/24, 17:47