87292[FEATURE] Change language TCA for fields of type file
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 38
- typo3/sysext/core/Configuration/TCA/pages.php+5 −0
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+8 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-83970-ChangeTCASettingsForFileFieldsForBetterLanguageSynchronization.rstnew+77 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/DataSet/localizeContentChainOfRelationWSynchronizationSource.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/Modify/DataSet/localizeContentOfRelationWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizeParentContentSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/DataSet/localizeContentChainOfRelationNAddCategoryWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/DataSet/localizeContentOfRelationNAddCategoryWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/DataSet/localizeContentOfRelationWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/Modify/DataSet/localizeContentOfRelationWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/localizeContentChainOfRelationNAddCategoryWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/localizeContentOfRelationNAddCategoryWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/localizeContentOfRelationWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesModify/DataSet/localizeContentOfRelationWSynchronization.csv+1 −1
Show 18 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/localizeContentChainOfRelationNAddCategoryWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/localizeContentOfRelationWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublish/DataSet/localizeContentOfRelationWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/localizeContentChainOfRelationNAddCategoryWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/localizeContentOfRelationWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/ManyToMany/WorkspacesPublishAll/DataSet/localizeContentOfRelationWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/createLocalizedContent.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/createLocalizedContentWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/createLocalizedContentWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationDefault.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContentFromNonDefaultLanguageWSynchronizationSource.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContentWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/localizeContentWSynchronizationHNull.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/Modify/DataSet/modifyTranslatedContent.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/Modify/DataSet/localizeNestedPagesAndContents.csv+3 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/Modify/DataSet/localizePageAndContentsAndDeletePageLocalization.csv+1 −1
- typo3/sysext/frontend/Configuration/TCA/tt_content.php8+16 −3
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php+10 −0
Review log 2736
Show 811 earlier messages
-
Sybille Peters uploaded patch set 1 11/30/24, 15:32
-
core-ci voted on patch set 1 V -1 11/30/24, 15:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70388
-
Sybille Peters uploaded patch set 2
V -111/30/24, 16:57 -
core-ci voted on patch set 2 V -1 11/30/24, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70396
-
Sybille Peters uploaded patch set 3
V -111/30/24, 19:37 -
core-ci voted on patch set 3 V +1 11/30/24, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70398
-
Garvin Hicking commented on patch set 3 12/06/24, 14:27
I asked in #typo3-translation-handling whether this change could have problamtic impact. They discussed this in their team meeting today, this is the short note from André Buchmann on it: --- * allowLanguageSynchronisation = true for the field type "File" in general -> Breaking change is ok for 14 * No UpgradeWizard needed: Should be handled by the DataHandler * DataHandler checks if allowLangSync is active and when l10n_state = NULL: * Compare translation value against source * On difference set l10n_state to custom * else set l10n_state to default * Comparison needs to check the child record in depth (same image, meta-title,...) --- Will try to give more feedback next week. -
Sybille Peters commented on patch set 3 12/06/24, 14:42
Reply Unresolved
Thank you Garvin. So todos are now: - remove upgrade wizard - change to TASK (we discussed this earlier) correct? Should this be marked as "breaking" with "!!!"? It is not really breaking, is it? -
Sybille Peters commented on patch set 3 12/07/24, 06:59
tt_content.php:366Should the becaviour of other fields of type=>file be changes as well? - pages.media: already has allowLanguageSynchronization - sys_file_collection.files? - tt_content.image? - tt_content.media? in ext:seo: - pages.og_image - twitter_image -
Benni Mack commented on patch set 3 12/13/24, 14:51
I think this change is valuable and maybe an option for other fields as well. I think we should fix this one first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62192 -
Sybille Peters commented on patch set 3 12/15/24, 10:48
tt_content.php:374I am having doubts about the setting allowLanguageSynchronization. In tt_content.assets it is recommended to set at least the field "alternative". It even says so in the description. This is important for accessibility and is a field which will usually be translated. Also the other fields - if set - will be translated. So allowLanguageSynchronization should probably only be set where there are no such fields to be translated. The other fields still make sense (createNewRelationLinkTitle, showAllLocalizationLink, showPossibleLocalizationRecords, showSynchronizationLink), I think but I will do some more checking and try to come up with a better default.
-
Sybille Peters uploaded patch set 4
V +112/15/24, 10:50 -
Sybille Peters voted on patch set 4 CR -1 12/15/24, 10:51
-
Sybille Peters uploaded patch set 5
CR -112/15/24, 10:54 -
core-ci voted on patch set 4 V +1 12/15/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71135
-
core-ci voted on patch set 5 V +1 12/15/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71136
-
Sybille Peters commented on patch set 5 12/15/24, 11:38
tt_content.php:374ReplyApparently, I was wrong. It is still possible to translate the texts (alternative, title etc.) if "Value of default language" is used. This is pretty great because then we have no problem using this as default. -
Sybille Peters commented on patch set 5 12/15/24, 12:23
@gh@faktor-e.de Are you sure we don't need the Upgrade wizard? (I already removed it but can be restored): I tested the following 1. Create a "textmedia", add 1 file, translate the record, add another file in translated ce. So we have 1 file in orig lang, 2 files in translation 2. Now change TCA as proposed, flush cache Now we still have 1 file in default and 2 files in translation (as before), but the value is set to "Value of default language". I think if the files are different and this is assumed to be correct, it should be set to "Custom value", which was the purpopse of the Upgrade Wizard. 3. Now add another file in default language and save Both records now have the files as just changed, so now the files of the translation are being overridden. My intention was to not make sudden changes to EXISTING content. I think the existing content should stay as is. -
Sybille Peters commented on patch set 5 12/15/24, 12:24
Reply Unresolved
Is not resolved. -
Sybille Peters commented on patch set 5 CR -1 12/15/24, 12:39
Feature-83970-ChangeTCASettingsForTt_contentassetsForBetterLanguageSynchronization.rst:36UnresolvedOverriding the settings with page TSConfig did not really work for me. This should be checked and possibly the snippet fixed. -
Sybille Peters uploaded patch set 6
CR -1V +112/15/24, 12:44 -
Sybille Peters commented on patch set 5 CR -1 12/15/24, 12:46
tt_content.php:366ReplyThe settings for the following fields is now changed (see Changelog): - pages.media (in tab "Resources") - sys_file_collection.files - tt_content.assets (e.g. in "Text & Media" = CType:textmedia) - tt_content.image (e.g. in "Text & Images" = CTpye:textpic) - tt_content.media (e.g. in CType:uploads) in ext:seo (tab "Social media"): - pages.og_image - pages.twitter_image -
core-ci voted on patch set 6 V -1 12/15/24, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71137
-
Sybille Peters uploaded patch set 7
V -112/15/24, 14:29 -
core-ci voted on patch set 7 V -1 12/15/24, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71138
-
Sybille Peters uploaded patch set 8
V -112/15/24, 19:34 -
core-ci voted on patch set 8 V -1 12/15/24, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71143
-
Sybille Peters commented on patch set 8 12/16/24, 18:12
This should get fixed first (see comment Benni): https://review.typo3.org/c/Packages/TYPO3.CMS/+/62192 -
Eric Harrer commented on patch set 8 12/19/24, 15:22
tt_content.php:321The label key should remain “images.addFileReference” here -
Eric Harrer commented on patch set 8 12/19/24, 15:28
tt_content.php:596The label key should remain “media.addFileReference” here -
Sybille Peters uploaded patch set 9
V -112/19/24, 19:44 -
Sybille Peters commented on patch set 8 12/19/24, 19:45
Reply
Donett_content.php:321ReplyDonett_content.php:596ReplyI am not really sure why I added that in the first place. It wasn't really that relevant to the change. I removed all the added createNewRelationLinkTitle now. -
core-ci voted on patch set 9 V -1 12/19/24, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71471
-
Sybille Peters commented on patch set 9 12/19/24, 21:54
Reply Unresolved
not resolved -
Sybille Peters commented on patch set 9 CR -1 01/15/25, 10:14
Unresolved
Specifically for allowLanguageSynchronization in combination with type file, there may be other issues still open which I would consider blocking if this leads to problems: * multiple issues: https://forge.typo3.org/issues/88766 * allowLanguageSynchronization doesn't synchronise cropping from images: https://forge.typo3.org/issues/88024 Ideally, test if these problems still exist with current main -
Sybille Peters abandoned the change 04/06/25, 07:03
Too many blocking issues still open, see comments