87362[TASK] Provide more tests for DataMapFactory
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 3
Files 7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RestrictedComment.phpnew+90 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/RestrictedCommentRepository.phpnew+32 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_restrictedcomment.phpnew+48 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlf+18 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/Fixtures/DataMapperCustomRestrictionFields.csvnew+3 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapFactoryTest.php+20 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+92 −33
Review log 58
-
Garvin Hicking commented on patch set 1 12/04/24, 16:41
Cherry Picked from branch main. -
core-ci voted on patch set 1 V -1 12/04/24, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70600
-
Garvin Hicking uploaded patch set 2 12/04/24, 16:56
Fix Test Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 2 V -1 12/04/24, 17:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70601
-
Garvin Hicking uploaded patch set 3
V -112/04/24, 17:06For real now -
core-ci voted on patch set 3 V +1 12/04/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70602
-
Garvin Hicking voted on patch set 3 CR +2 V +2 12/04/24, 17:25
-
Garvin Hicking merged patch set 4 12/04/24, 17:26