Review 13.4 Merged

87411[BUGFIX] Remove inconvenient nullable checkbox from datetime elements

Benjamin Franzke CR +2 V +2 Easy +1 −14 updated 12/10/24, 08:25

Commit message

The "Set value" checkbox is removed in order to increase user
experience, as a (nullable) datetime can handle the difference between
having a date set (concrete date value) and having no date
(input field is empty) itself.
An additional checkbox that disables the input field is superfluous,
confusing for editors and the checkbox-barrier actually prevented fast
user interaction, as two clicks were needed to start selecting a date.

Since #105666 an empty datepicker input is properly converted to
NULL by DataHandler for all dbType fields, which renders the
null-checkbox technically useless and allows this change to be
performed now.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 12/10/24, 08:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/10/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70848

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 12/10/24, 08:25

  4. Benjamin Franzke merged patch set 2 12/10/24, 08:25