Review 13.4 Merged

87412[BUGFIX] Restore setting default lib.parseFunc.allowTags / denyTags

Garvin Hicking CR +2 V +2 Normal +122 −0 updated 12/10/24, 10:29

Commit message

With #104220 a change of behaviour was introduced that no longer
sets `lib.parseFunc_RTE.allowTags = {$styles.content.allowTags}`.

If custom extensions like a sitepackage however previously used this
code:

```
lib.parseFunc.allowTags := addToList(wbr)
lib.parseFunc_RTE.allowTags := addToList(wbr)
```

then `addToList` would actually set the previously empty `allowTags`
ONLY to "wbr". This would then deny any tag besides "wbr", and not
just allow "wbr" additionally to the previous default.

This patch re-introduces the `allowTags=*` TypoScript definition,
so that it can be expanded. Also, it ensures that any setting like
`*,wbr` still enables wildcard parsing.

Tests are added to verify this functionality.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 46

  1. Garvin Hicking commented on patch set 1 12/10/24, 08:27

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/10/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70849

  3. Benjamin Franzke uploaded patch set 2 12/10/24, 10:20

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  4. Benjamin Franzke commented on patch set 2 12/10/24, 10:21

    Sorry, I only noticed that you already prepared the backport after pushing from local 13 checkout (which I used to test this). Will now wait for CI again…
  5. core-ci voted on patch set 2 V +1 12/10/24, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70851

  6. Benjamin Franzke merged patch set 3 12/10/24, 10:29