Review 12.4 Merged

87430[BUGFIX] Use correct default value for extTarget in tsref.xml

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 12/11/24, 10:12

Commit message

In the settings.definitions.yaml (v13) and constants.typoscript
(v12) the value "_blank" is defined as default value.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Garvin Hicking commented on patch set 1 12/11/24, 09:19

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Private/tsref.xml
  2. Garvin Hicking uploaded patch set 2 12/11/24, 09:24

    manual backport
  3. Garvin Hicking marked it ready for review 12/11/24, 09:24

  4. core-ci voted on patch set 1 V +1 12/11/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70906

  5. core-ci voted on patch set 2 V +1 12/11/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70907

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 12/11/24, 10:12

  7. Garvin Hicking merged patch set 3 12/11/24, 10:12