Review 13.4 Merged

87512[BUGFIX] Use proper surrounding "html" tags for Fluid SystemEmail

Garvin Hicking CR +2 V +2 Normal +89 −1 updated 12/16/24, 15:56

Commit message

Due to usage of `data-namespace-typo3-fluid="true"` in the
`<html>` declaration of the file
`EXT:core/Resources/Private/Layouts/SystemEmail.html`,
the whole `<html>..</html>` structure is removed from a sent
HTML mail.

Validation and possibly utilities like SpamAssassin may fail
or negatively score these mails due to these tags being missing.

Since the xmlns declaration of the ViewHelpers is semantically
not wrong, it can actually be included in the email by removing
the `data-namespace-typo3-fluid` attribute, instead of requiring
the alternate more intrusive Fluid ViewHelper declaration.

Custom adaptations of the SystemEmail template should be adjusted.

Note that usually mail clients or web-based mail clients usually
are fault-tolerant and replace the doctype and html tag declaration
on their own for display, so the (positive) impact of this change is
probably low.

Tests are adapted to match this expectation.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Garvin Hicking commented on patch set 1 12/16/24, 15:39

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/16/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71203

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 12/16/24, 15:56

  4. Garvin Hicking merged patch set 2 12/16/24, 15:56