Review 13.4 Merged

87560[BUGFIX] Improve ARIA-attributes of Lit Element tree

Oli Bartsch CR +2 V +2 Easy +12 −12 updated 12/18/24, 14:46

Commit message

This improves the ARIA-attributes of the Lit Element trees treeitems.

`aria-owns` and `aria-expanded` must not have an empty value. Only
render them if there are child-treenodes and therefore their value is
not empty.
Without this change these attributes were rendered with an empty value.

`aria-level` must be a positive integer, therefore `0` is not allowed.
See:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-level#values

`div` tags must not be rendered inside `span` tags.
This changes `span` tags to `div` if they contain `div` tags.
All changed `span` tags already have set CSS `display: flex`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 12/18/24, 14:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/18/24, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71387

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/18/24, 14:45

  4. Oli Bartsch merged patch set 2 12/18/24, 14:46