Review 13.4 Merged

87562[BUGFIX] Compare new site properties with unprocessed current properties

Garvin Hicking CR +2 V +2 Normal +64 −2 updated 01/20/25, 15:31

Commit message

Writing modified site configuration from the sites backend module
currently compares unprocessed new configuration with processed current
configuration. This causes problems when using placeholders in imported
YAML files.

With this change, the diff behavior when writing modified site config
is changed: New configuration properties are now compared against the
unprocessed current configuration properties. For current configuration,
YAML imports are still processed, whereas placeholder processing is
skipped.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 58

  1. Garvin Hicking commented on patch set 1 12/18/24, 16:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 12/18/24, 17:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71398

  3. Elias Häußler uploaded patch set 2 V -1 12/18/24, 18:36

  4. core-ci voted on patch set 2 V +1 12/18/24, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71408

  5. Elias Häußler rebased onto patch set 3 V +1 01/20/25, 10:32

  6. core-ci voted on patch set 3 V +1 01/20/25, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72721

  7. Garvin Hicking voted on patch set 3 CR +2 V +2 01/20/25, 15:31

  8. Garvin Hicking merged patch set 4 01/20/25, 15:31