Review 12.4 Merged

87563[BUGFIX] Compare new site properties with unprocessed current properties

Garvin Hicking CR +2 V +2 Normal +59 −2 updated 01/20/25, 15:31

Commit message

Writing modified site configuration from the sites backend module
currently compares unprocessed new configuration with processed current
configuration. This causes problems when using placeholders in imported
YAML files.

With this change, the diff behavior when writing modified site config
is changed: New configuration properties are now compared against the
unprocessed current configuration properties. For current configuration,
YAML imports are still processed, whereas placeholder processing is
skipped.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Garvin Hicking commented on patch set 1 12/18/24, 16:59

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Configuration/SiteWriter.php * typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php
  2. core-ci voted on patch set 1 V -1 12/18/24, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71399

  3. Garvin Hicking uploaded patch set 2 V -1 12/18/24, 17:09

    manual backport
  4. Garvin Hicking marked it ready for review 12/18/24, 17:09

  5. core-ci voted on patch set 2 V +1 12/18/24, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71400

  6. Elias Häußler voted on patch set 2 CR +1 V +1 12/18/24, 18:03

  7. Garvin Hicking rebased onto patch set 3 CR +1 V +1 01/20/25, 10:32

  8. core-ci voted on patch set 3 V +1 01/20/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72720

  9. Garvin Hicking voted on patch set 3 CR +2 V +2 01/20/25, 15:31

  10. Garvin Hicking merged patch set 4 01/20/25, 15:31