Review 13.4 Merged

87571[BUGFIX] Ensure Indexed Search can handle PPTX and XLSX files

Benni Mack CR +2 V +2 Easy +36 −8 updated 12/19/24, 15:21

Commit message

Thanks to Xavier Perseguers for providing this fix
which properly indexes XLSX and PPTX files.

Problem for XLSX was that the wrong "unzipped" file was indexed,
a file that contains some kind of metadata which are basically only
pointers (integers). The content extracted is plain wrong and useless.

Problem for PPTX was that only the content of Slide 1 was extracted,
it missed content from all other slides.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/19/24, 15:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/19/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71457

  3. Benni Mack voted on patch set 1 CR +2 V +2 12/19/24, 15:21

  4. Benni Mack merged patch set 2 12/19/24, 15:21