Review 13.4 Merged

87573[BUGFIX] Align markup in scheduler forms to match display in formengine forms

Jasmina Ließmann CR +2 V +2 Hard +303 −285 updated 12/19/24, 18:03

Commit message

With #104676, the form styling was changed, resulting in a changed
appearance/behavior of form groups that are nested in multiple form
rows. The changed form styling explicitly removes the spacing of the
last form group in a form section.

Since each form group in the scheduler was previously in its own form
row, this condition was always met and resulted in a reduced spacing
between most form fields within the scheduler add/edit forms.

This patch restores the spacing between the form fields in scheduler
add/edit forms by using only one form row per form section.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • core-ci +1 CI

Issues 1

Files 10

Review log 34

  1. Jasmina Ließmann commented on patch set 1 12/19/24, 17:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/19/24, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71465

  3. Jasmina Ließmann voted on patch set 1 CR +2 V +2 12/19/24, 18:03

  4. Jasmina Ließmann merged patch set 2 12/19/24, 18:03