Review 13.4 Merged

87578[BUGFIX] Remove redundant overrideChildTca from image fields

Oli Bartsch CR +2 V +2 Normal +18 −150 updated 12/20/24, 08:27

Commit message

Since #101277 the behavior for file fields was changed to have the full
palette (imageOverlayPalette, audioOverlayPalette, ...) per default.
Now, the old overrideChildTca definitions for image fields can be
removed, greatly simplifying the TCA definition.

Some fields defined the imageOverlayPalette for type "unknown" and
"text" (see #79622, #56884 and #33752). This is obviously a
misconfiguration and will lead to an unusable crop field. The fields
"alternative" and "link" don't make sense either for type text.

For backwards compatibility, this patch adds an intermediate palette
called "extendedBasicOverlayPalette", which keeps the "alternative" and
"link" fields for type unknown, text and application. This workaround
should be removed again in v14.

Styleguide can be safely changed, as it's not API.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 5

Files 8

Review log 34

  1. Oli Bartsch commented on patch set 1 12/20/24, 08:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/20/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71497

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 12/20/24, 08:27

  4. Oli Bartsch merged patch set 2 12/20/24, 08:27