Review 13.4 Merged

87624[BUGFIX] Make install command accept create-site 'no'

Stefan Bürk CR +2 V +2 Easy +5 −11 updated 01/02/25, 12:23

Commit message

When you run the setup command without parameter you are informed
that the default for "create a basic site" is "no." However using
"no" as value for either the argument `--create-site` or the
enviroment variable `TYPO3_SETUP_CREATE_SITE=no` currently causes
errors:

In SetupCommand.php line 626:

The given url for the site name is not valid! Please try again.

Instead of "normalizing" just the user input of the command prompt,
all possible input ways (prompt, argument, variable) the same way by
leaving the interpretation of the input to the validator.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 01/02/25, 11:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/02/25, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71824

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/02/25, 12:23

  4. Stefan Bürk merged patch set 2 01/02/25, 12:23