Review 13.4 Merged

87633[DOCS] Use ServerRequestInterface $request parameter in AbstractPlugin

Stefan Bürk CR +2 V +2 Easy +22 −2 updated 01/04/25, 16:01

Commit message

The example of the breaking change to AbstractPlugin (removed in v13)
is missing the third parameter `$request`. It is passed to the
TS userfunc execution [1] [2].

This patch makes the migration example more complete for v12 instances.

[1] https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/RequestLifeCycle/Typo3Request.html#user-function
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/66080

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 01/04/25, 15:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/04/25, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71914

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 01/04/25, 16:01

  4. Stefan Bürk merged patch set 2 01/04/25, 16:01