Review 13.4 Merged

87643[TASK] Adjust variable check and remove warning from PHPStan baseline

Garvin Hicking CR +2 V +2 Easy +1 −7 updated 01/06/25, 11:07

Commit message

The variable check on `$selectableItemGroups[<int>]['items']` can
be simplified. Only the method itselfs sets that self-created
temporary array structure, there is no outside manipulation of it.

Thus, if the array key 'items' is present, it will always be filled.

Executed command:

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 01/06/25, 10:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/06/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71975

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 01/06/25, 11:07

  4. Garvin Hicking merged patch set 2 01/06/25, 11:07