Review 12.4 Merged

87664[TASK] Add ScalarStringMatcher Extension Scanner for TYPO3_MODE reports

Garvin Hicking CR +2 V +2 Hard +271 −0 updated 01/09/25, 14:27

Commit message

An upgrade to TYPO3 v12 can be painful when backend or frontend
modules (or even the Database Analyzer) bails out with a white
page. Usually this would lead to inspection of logfiles,
checking if PHP's `error_reporting` or `display_errors` is
not properly set, looking for PHP/Webserver coredumps,
problems in HTTP headers, CSP errors and much more, just
to find out that a

  `defined('TYPO3_MODE') or die()`

was left in some PHP file of an extension, which needs
to be replaced with `TYPO3` (see #92947 and #96107).

The Extension Scanner only scanned for the full
PHP constant usage before.

With this patch, these "magic strings" can now also
be scanned and reported, making debugging of a
malfunctioning upgrade much easier for developers
and especially integrators.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 711

  1. Garvin Hicking commented on patch set 1 01/08/25, 11:36

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 01/08/25, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72087

  3. Garvin Hicking uploaded patch set 2 V -1 01/08/25, 15:34

    Adjust to old php parser
  4. core-ci voted on patch set 2 V -1 01/08/25, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72101

  5. Garvin Hicking uploaded patch set 3 V -1 01/08/25, 17:02

    Adjust again
  6. core-ci voted on patch set 3 V +1 01/08/25, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72108

  7. Garvin Hicking uploaded patch set 4 V +1 01/08/25, 17:12

    whitespace
  8. core-ci voted on patch set 4 V +1 01/08/25, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72109

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 01/09/25, 14:17

  10. Garvin Hicking voted on patch set 4 CR +2 V +2 01/09/25, 14:26

  11. Garvin Hicking merged patch set 5 01/09/25, 14:27